New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let #load_site not set site ivar #1213

Merged
merged 1 commit into from Sep 3, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Sep 3, 2017

The mutable state introduced by letting #load_site set the @site ivar is troubling (see #1211 for a case where I was bitten by this).

This PR lets #load_site return the new site, rather than set @site. I’ve opted to let the command runners assign the return value of #load_site to @site, which, even though not perfect, is more reasonable.

@ddfreyne ddfreyne merged commit d36cb4a into master Sep 3, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.71%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.28% compared to b2e0cec
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the immutable-load-site branch Sep 3, 2017

@ddfreyne ddfreyne referenced this pull request Sep 3, 2017

Closed

Site loading skipped #1211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment