Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make #raw_path public #1231

Merged
merged 10 commits into from Oct 8, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Oct 7, 2017

  • Remove certain methods from item rep views when in non-compilation context.
    • #raw_path (will fix #1228)
    • #compiled_content
  • Mark #raw_path as public
  • Refactor: Specialise ItemRepCollectionView

CC @gpakosz @moll

@ddfreyne ddfreyne force-pushed the public-item-rep-raw-path branch 3 times, most recently from 2e579be to 9a49c08 Oct 7, 2017

@ddfreyne ddfreyne force-pushed the public-item-rep-raw-path branch from 96689fb to 0f3ed2f Oct 7, 2017

@ddfreyne ddfreyne force-pushed the public-item-rep-raw-path branch from 43ffcf1 to c0a2606 Oct 8, 2017

@ddfreyne ddfreyne force-pushed the public-item-rep-raw-path branch from 61bf442 to 445db3f Oct 8, 2017

@ddfreyne ddfreyne force-pushed the public-item-rep-raw-path branch from a52d21d to c922ef2 Oct 8, 2017

@ddfreyne ddfreyne merged commit 2b4385a into master Oct 8, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.54%)
Details
codecov/project 98.54% (+<.01%) compared to ecfdf7e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the public-item-rep-raw-path branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.