New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat LoadErrors for known gems as trivial #1274

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Dec 14, 2017

Fixes part of #1273.

  • Known gems: e.g. require 'nokogiri' -> considered a trivial LoadError; Nanoc will tell you to add nokogiri to the Gemfile.

  • Unknown gems: Usual stack trace.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Dec 14, 2017

Member

The error message is still crappy:

% bundle exec nanoc
Loading site… Error: cannot load such file -- nokogiri
Make sure the gem is added to Gemfile and run `bundle install`.

Better:

% bundle exec nanoc
Loading site…

Error: cannot load such file -- nokogiri

1.  Add the `nokogiri` gem to your Gemfile:

        gem 'nokogiri'

2.  Run `bundle`

3.  Re-run `bundle exec nanoc`
Member

ddfreyne commented Dec 14, 2017

The error message is still crappy:

% bundle exec nanoc
Loading site… Error: cannot load such file -- nokogiri
Make sure the gem is added to Gemfile and run `bundle install`.

Better:

% bundle exec nanoc
Loading site…

Error: cannot load such file -- nokogiri

1.  Add the `nokogiri` gem to your Gemfile:

        gem 'nokogiri'

2.  Run `bundle`

3.  Re-run `bundle exec nanoc`

@ddfreyne ddfreyne merged commit fbe43d6 into master Dec 15, 2017

3 checks passed

codecov/patch Coverage not affected when comparing afa86f0...2cad67f
Details
codecov/project 98.16% (+0.03%) compared to afa86f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the treat-known-load-errors-as-trivial branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment