New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let #breadcrumbs_trail always find closest parent #1279

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Dec 21, 2017

Fixes #1278.

#breadcrumbs_trail already supported cases like these:

/index.md
/foo.md.erb
/foo/stuff.html

# trail = [/index.md, /foo.md.erb, /foo/stuff.html]

but now it will also support

/index.md
/1.2.erb
/1.2/stuff.html

# trail = [/index.md, /1.2.erb, /1.2/stuff.html]
@iay

This comment has been minimized.

Show comment
Hide comment
@iay

iay Dec 21, 2017

Contributor

The fancy functional programming stuff is beyond my 2006-vintage understanding of Ruby but the intent seems right. I will try and do a quick test of this tomorrow and let you know whether it works for my case.

Contributor

iay commented Dec 21, 2017

The fancy functional programming stuff is beyond my 2006-vintage understanding of Ruby but the intent seems right. I will try and do a quick test of this tomorrow and let you know whether it works for my case.

@iay

This comment has been minimized.

Show comment
Hide comment
@iay

iay Dec 22, 2017

Contributor

Dropping the modified breadcrumbs.rb into my lib/ directory seems to fix my particular use case.

Contributor

iay commented Dec 22, 2017

Dropping the modified breadcrumbs.rb into my lib/ directory seems to fix my particular use case.

@ddfreyne ddfreyne merged commit fe0d74a into master Dec 22, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 1429267...6a09054
Details
codecov/project 98.42% (+<.01%) compared to 1429267
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the gh-1278 branch Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment