Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Identifier#match? #1305

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Jan 26, 2018

Rubocop suggests changing x =~ /foo/ to x.match?(/foo/), but that fails when x is an identifier rather than a string.

@ddfreyne ddfreyne force-pushed the add-identifier-match-eh branch from 05a4abc to 21d5773 Jan 26, 2018

@ddfreyne ddfreyne merged commit a8a345e into master Jan 26, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 4630125...21d5773
Details
codecov/project 98.48% (+<.01%) compared to 4630125
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the add-identifier-match-eh branch Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.