Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle gcse:search #1320

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

commented Feb 21, 2018

Fixes #1319.

This isn’t pretty, but Nokogiri/libxml don’t offer a clean solution.

@sirosen

This comment has been minimized.

Copy link

commented Feb 21, 2018

Thanks for the super-quick turnaround from bug report to fix!
The fix looks reasonable to me (though I agree, not pretty) -- test failure doesn't seem related, maybe an intermittent bug in the testsuite or a ruby2.3 issue.

This is almost the same as the fix we worked out in the project where #1319 surfaced, using a custom filter.

If you want to be super paranoid, you could use ENV['NANOC_GCSE_WORKAROUND'] || 'nanoc__gcse_search_workaround'.
Probably not necessary, to the point where I won't even advocate for it, but if you worry that this string might actually appear in content in the future, it's an easy out.

@ddfreyne ddfreyne force-pushed the gh-1319 branch from 3d601b2 to e14e0e6 Feb 22, 2018

@ddfreyne ddfreyne merged commit 1700ac5 into master Feb 22, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 66532ce...e14e0e6
Details
codecov/project 98.49% (-0.01%) compared to 66532ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2018

test failure doesn't seem related

One of Nanoc’s tests became rather flaky lately. Definitely something I’m looking into.

@ddfreyne ddfreyne deleted the gh-1319 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.