Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title_proc parameter to blogging helper. #1362

Closed
wants to merge 1 commit into from

Conversation

@th-h
Copy link
Contributor

@th-h th-h commented Oct 3, 2018

title_proc can be used to transform the title of each item in an Atom feed, like content_proc or excerpt_proc do for content or excerpt.

Closes nanoc/features#42

To do

  • Add / expand tests.
  • Add documentation.

Signed-off-by: Thomas Hochstein thh@inter.net

title_proc can be used to transform the title of each
item in an Atom feed, like content_proc or excerpt_proc
do for content or excerpt.

Closes nanoc/features#42

Signed-off-by: Thomas Hochstein <thh@inter.net>
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 3, 2018

Looks good so far!

Do you want assistance with the tests?

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 3, 2018

@th-h I think I can take over this PR if you want me to lend a hand with the tests!

Loading

@th-h
Copy link
Contributor Author

@th-h th-h commented Oct 3, 2018

That would be fine! I fear I'm out of my depth ...

Loading

@ddfreyne ddfreyne mentioned this pull request Oct 4, 2018
2 tasks
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 4, 2018

I’ve created a separate PR (#1363) with your code + a test.

I can also handle the documentation (that’s in the nanoc.ws repository).

Loading

@ddfreyne ddfreyne closed this Oct 4, 2018
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 4, 2018

Merged! Thanks for the contribution!

A release will follow later this week.

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 5, 2018

This is released as part of Nanoc 4.9.8!

Loading

@th-h th-h deleted the thh-title_proc branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants