New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title_proc parameter to blogging helper. #1362

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@th-h
Contributor

th-h commented Oct 3, 2018

title_proc can be used to transform the title of each item in an Atom feed, like content_proc or excerpt_proc do for content or excerpt.

Closes nanoc/features#42

To do

  • Add / expand tests.
  • Add documentation.

Signed-off-by: Thomas Hochstein thh@inter.net

Add title_proc parameter to blogging helper.
title_proc can be used to transform the title of each
item in an Atom feed, like content_proc or excerpt_proc
do for content or excerpt.

Closes nanoc/features#42

Signed-off-by: Thomas Hochstein <thh@inter.net>

@th-h th-h referenced this pull request Oct 3, 2018

Closed

title_proc in blogging helper #42

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Oct 3, 2018

Member

Looks good so far!

Do you want assistance with the tests?

Member

ddfreyne commented Oct 3, 2018

Looks good so far!

Do you want assistance with the tests?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Oct 3, 2018

Member

@th-h I think I can take over this PR if you want me to lend a hand with the tests!

Member

ddfreyne commented Oct 3, 2018

@th-h I think I can take over this PR if you want me to lend a hand with the tests!

@th-h

This comment has been minimized.

Show comment
Hide comment
@th-h

th-h Oct 3, 2018

Contributor

That would be fine! I fear I'm out of my depth ...

Contributor

th-h commented Oct 3, 2018

That would be fine! I fear I'm out of my depth ...

@ddfreyne ddfreyne referenced this pull request Oct 4, 2018

Merged

title_proc for the blogging helper #1363

1 of 2 tasks complete
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Oct 4, 2018

Member

I’ve created a separate PR (#1363) with your code + a test.

I can also handle the documentation (that’s in the nanoc.ws repository).

Member

ddfreyne commented Oct 4, 2018

I’ve created a separate PR (#1363) with your code + a test.

I can also handle the documentation (that’s in the nanoc.ws repository).

@ddfreyne ddfreyne closed this Oct 4, 2018

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Oct 4, 2018

Member

Merged! Thanks for the contribution!

A release will follow later this week.

Member

ddfreyne commented Oct 4, 2018

Merged! Thanks for the contribution!

A release will follow later this week.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Oct 5, 2018

Member

This is released as part of Nanoc 4.9.8!

Member

ddfreyne commented Oct 5, 2018

This is released as part of Nanoc 4.9.8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment