New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure breadcrumb trail always ends in item itself #1367

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Oct 8, 2018

Detailed description

The items in the path are up for interpretation (but not too much — see below), but the one at the very end, the item for which the breadcrumb is generated, definitely not.

As it stands right now, #breadcrumbs_trail makes a decision which parent to use. This might not be the right thing to do; when there is ambiguity, it might make more sense to raise an error instead. Perhaps it needs a strict: false (default true) option?

To do

  • Tests

Related issues

Fixes #1366.

ddfreyne added some commits Oct 8, 2018

@ddfreyne ddfreyne merged commit 2efe0fd into master Oct 8, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 439fcd0...34e42eb
Details
codecov/project 98.45% (+<.01%) compared to 439fcd0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the breadcrumb-trail-end-in-item-itself branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment