New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when meta-file cannot be unambiguously associated #1370

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Oct 13, 2018

Fixes #1369.

Detailed description

In the case where there is on meta-file, and

  • … two or more content files, all without inline metadata: raise error
  • … two or more content files, all with inline metadata: raise error
  • … exactly one content file without inline metadata: use attributes from the meta-file

To do

(Include the to-do list for this PR to be finished here.)

  • Tests
  • Documentation
  • Refactoring (but maybe later)

Related issues

#1369

@ddfreyne ddfreyne merged commit f83b965 into master Oct 13, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 2efe0fd...5d907bc
Details
codecov/project 98.46% (+<.01%) compared to 2efe0fd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the filesystem-meta-ambiguity branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment