New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy-load Sass #1371

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Oct 16, 2018

This will Nanoc not always load Sass, but only when the :sass filter is used.

Without this, users of Nanoc 4.10.0 would get

1: from /usr/local/lib/site_ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in require' /usr/local/lib/site_ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:inrequire': cannot load such file -- sass (LoadError)

To do

  • Tests — but this is particularly hard to test…

Related issues

(none)

@ddfreyne ddfreyne merged commit 1af2ab9 into master Oct 16, 2018

3 checks passed

codecov/patch Coverage not affected when comparing f71a10a...f920841
Details
codecov/project 98.42% (+<.01%) compared to f71a10a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the optional-sass branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment