Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let RulesModified check dependent objects as well #1373

merged 1 commit into from Oct 21, 2018


None yet
1 participant
Copy link

commented Oct 21, 2018

When the params of a layout were changed, Nanoc wouldn’t recompile items that use this layout, because it only checked the rules of the item itself — not of the layout that it depends on.

To do

  • Tests
    • Regression test
    • Test to verify filter used for layout

Related issues

Fixes #1372.

@ddfreyne ddfreyne force-pushed the let-layout-params-affect-rules branch from deccf81 to ff2babf Oct 21, 2018

@ddfreyne ddfreyne merged commit 0358044 into master Oct 21, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 4ac8df1...ff2babf
codecov/project 98.43% (+<.01%) compared to 4ac8df1
continuous-integration/travis-ci/pr The Travis CI build passed

@ddfreyne ddfreyne deleted the let-layout-params-affect-rules branch Oct 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.