Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let `write nil` always skip routing rule #1375

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Oct 21, 2018

Detailed description

The skip_routing_rule was properly set up, but somehow not used.

If, after snapshot compaction, there is any path assigned to a snapshot action, the routing rule will be skipped. For example:

  1. snapshot a, no paths
  2. snapshot b, some paths
  3. any filter
  4. snapshot c, no paths

In the example above, only for snapshot c would the routing rule be used (if any).

To do

  • Tests

Related issues

Fixes #1374.

@ddfreyne ddfreyne force-pushed the write-nil branch 2 times, most recently from 8b8cf7a to f79bf90 Oct 21, 2018

@ddfreyne ddfreyne force-pushed the write-nil branch from f79bf90 to e5bf21a Oct 22, 2018

@ddfreyne ddfreyne merged commit 5b45e55 into master Oct 24, 2018

3 checks passed

codecov/patch Coverage not affected when comparing e20e84f...e5bf21a
Details
codecov/project 98.43% (+<.01%) compared to e20e84f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the write-nil branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.