New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On EACCES, copy instead of hardlink #1406

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

ddfreyne commented Feb 9, 2019

Fixes #1405. (Or rather, works around the issue…)

It is possible for hardlinking to fail when copying works fine. In that case, fall back to copying instead of hardlinking.

To do: Figure out a way to test this.

Why?

According to facebook/create-react-app#1832 (comment):

Due to Android's SELinux policies, you cannot hard link as non-root

@ddfreyne ddfreyne force-pushed the handle-eaccess-in-item-rep-writer branch from 1c2ec62 to f0f45dd Feb 9, 2019

@ddfreyne ddfreyne changed the title On EACCESS, copy instead of hardlink On EACCES, copy instead of hardlink Feb 9, 2019

@ddfreyne ddfreyne merged commit 57bc3c6 into master Feb 9, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@ddfreyne ddfreyne deleted the handle-eaccess-in-item-rep-writer branch Feb 9, 2019

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented Feb 9, 2019

CI isn’t my friend today (appears to be testing the wrong commit) but merging anyway (build passes locally) and will verify that master passes on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment