Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atom:link[type] attributes #1415

Merged
merged 1 commit into from Apr 24, 2019

Conversation

Projects
None yet
2 participants
@da2x
Copy link
Contributor

commented Apr 13, 2019

Detailed description

Adds media type hints to all links in Atom feeds. Adds the atom:link[type="text/html"] attribute to all web links and atom:link[type="application/atom+xml"] to the Atom self link.

RFC 4287 section 4.2.7.3.

To do

  • Approve and merge.
Add atom:link[type] attributes
RFC 4287 section 4.2.7.3
@ddfreyne

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

This looks great!

@da2x Could you also update the tests/specs to reflect this change? Once that’s done, I will merge.

(I can also take over the test/spec writing, but it will have to wait until next week at least.)

@da2x

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

I spent forever trying to get the tests running locally but never managed to get it going properly. It seems to run about halfway through the tests and then dies:

$ bundle exec rake test
(in /tmp/nanoc/nanoc)
bundle exec rake test
/usr/include/c++/9/bits/stl_vector.h:1042: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = v8::Handle<v8::Value>; _Alloc = std::allocator<v8::Handle<v8::Value> >; std::vector<_Tp, _Alloc>::reference = v8::Handle<v8::Value>&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
rake aborted!
Command failed with status (1): [bundle exec rake test...]
/tmp/nanoc/Rakefile:12:in `block (2 levels) in sub_sh'
/tmp/nanoc/Rakefile:10:in `chdir'
/tmp/nanoc/Rakefile:10:in `block in sub_sh'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler.rb:313:in `block in with_clean_env'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler.rb:562:in `with_env'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler.rb:313:in `with_clean_env'
/tmp/nanoc/Rakefile:9:in `sub_sh'
/tmp/nanoc/Rakefile:27:in `block (3 levels) in <top (required)>'
/usr/local/share/gems/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:74:in `load'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:74:in `kernel_load'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli/exec.rb:28:in `run'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli.rb:463:in `exec'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli.rb:27:in `dispatch'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/cli.rb:18:in `start'
/home/user/.gem/ruby/gems/bundler-2.0.1/exe/bundle:30:in `block in <top (required)>'
/home/user/.gem/ruby/gems/bundler-2.0.1/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
/home/user/.gem/ruby/gems/bundler-2.0.1/exe/bundle:22:in `<top (required)>'
/usr/bin/bundle:23:in `load'
/usr/bin/bundle:23:in `<main>'
Tasks: TOP => test => nanoc:test
@ddfreyne

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Yikes, an assertion failure in STL is strange indeed. I’ll test it out locally and merge it!

@ddfreyne ddfreyne merged commit 39df9bc into nanoc:master Apr 24, 2019

21 checks passed

ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing ecfff68...39df9bc
Details
codecov/project 97.93% remains the same compared to ecfff68
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.