Report permanent redirects as errors in :external_links #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report permanently redirected links as errors. In accordance with RFC 7538 and RFC 7231: Requests to permanently redirected URLs should not be repeated and the link should be updated to point to the new location not be repeated and the links should be updated.
|
Looks good! The style check fails because of a trailing whitespace character — I’ve fixed it and merged manually to master. |
denisdefreyne
added a commit
that referenced
this issue
May 4, 2019
Previously missing: Report permanent redirects as errors in :external_links (#1419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Detailed description
Report permanently redirected links as errors. Anyone concerned with link rot (e.g. anyone running this checker) will want to update their links as redirects tend to go away over time. This is the expected behavior for the 301 and 308 response codes in accordance with RFC 7538 and RFC 7231. I’ve written a wall of text on the subject for anyone who might be interested in the details.
Prior art: The popular (700k installs) Broken Link Checker plugin for WordPress reports on permanent redirects.
To do
If required then this should be some generic something to filter out errors by status codes rather than an off switch per check-criteria.