Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle external links list (:elinks checker) #1429

Merged
merged 1 commit into from May 4, 2019

Conversation

@da2x
Copy link
Contributor

commented May 1, 2019

Detailed description

Shuffle the list of links to test. The set will normally be sorted per item they were collected in and in many situation trend towards having the same origin repeated multiple times in a row.

Same-origin distance distribution (number of other links between links to the same origin) in my set of 2000+ links from 500 items before to change:

Min.   1st Qu.  Median    Mean   3rd Qu.    Max. 
 1.0       2.0    10.0   135.8     103.8  2089.0 

Same-origin distance distribution after to change:

Min.   1st Qu.  Median    Mean   3rd Qu.    Max. 
 1.0      15.0    52.5   207.0     202.0  1842.0

It’s not perfect but it’s an improvement.

Related issues

Shuffle external links
Improves on issue #1418.
@ddfreyne

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I like it! (Also props for adding statistical evidence ❤️)

I’m not sure whether it makes sense to add a test — randomness is rather hard to test for…

@ddfreyne ddfreyne merged commit 86255aa into nanoc:master May 4, 2019

21 checks passed

ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d0941cf...5117be7
Details
codecov/project 97.74% (+<.01%) compared to d0941cf
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.