Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle external links list (:elinks checker) #1429

Merged
merged 1 commit into from May 4, 2019
Merged

Conversation

da2x
Copy link
Contributor

@da2x da2x commented May 1, 2019

Detailed description

Shuffle the list of links to test. The set will normally be sorted per item they were collected in and in many situation trend towards having the same origin repeated multiple times in a row.

Same-origin distance distribution (number of other links between links to the same origin) in my set of 2000+ links from 500 items before to change:

Min.   1st Qu.  Median    Mean   3rd Qu.    Max. 
 1.0       2.0    10.0   135.8     103.8  2089.0 

Same-origin distance distribution after to change:

Min.   1st Qu.  Median    Mean   3rd Qu.    Max. 
 1.0      15.0    52.5   207.0     202.0  1842.0

It’s not perfect but it’s an improvement.

Related issues

@denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented May 4, 2019

I like it! (Also props for adding statistical evidence ❤️)

I’m not sure whether it makes sense to add a test — randomness is rather hard to test for…

@denisdefreyne denisdefreyne merged commit 86255aa into nanoc:master May 4, 2019
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants