Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crash in show-data when printing layout outdatedness #1432
Conversation
ddfreyne
added
the
type:bug 🐛
label
May 4, 2019
ddfreyne
force-pushed the
gh-1428-outdated-due-to-dependencies-for-layout
branch
from
5078ff4
to
5e09c2d
May 4, 2019
ddfreyne
merged commit 57fd535
into
master
May 4, 2019
21 checks passed
ci/circleci: check_style_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25
Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26
Your tests passed on CircleCI!
Details
codecov/patch
Coverage not affected when comparing f402851...5e09c2d
Details
codecov/project
97.74% (+<.01%) compared to f402851
Details
ddfreyne
deleted the
gh-1428-outdated-due-to-dependencies-for-layout
branch
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ddfreyne commentedMay 4, 2019
•
edited
Detailed description
show-dataprints the outdatedness status of layouts. Unfortunately, the tests mock out the outdatedness checker, and the real outdatedness checker does not permit callingoutdated_due_to_dependencies?on layouts, only items and item reps.This appears to be mostly a problem with the contracts that have been set up; the code appears to work fine without contracts in place.
Changing the
show-dataspecs to not mock the outdatedness checker is rather difficult at this point, however.To do
Related issues
Fixes #1428.