Fix crash in show-data when printing layout outdatedness #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
gh-1428-outdated-due-to-dependencies-for-layout
branch
from
5078ff4
to
5e09c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Detailed description
show-dataprints the outdatedness status of layouts. Unfortunately, the tests mock out the outdatedness checker, and the real outdatedness checker does not permit callingoutdated_due_to_dependencies?on layouts, only items and item reps.This appears to be mostly a problem with the contracts that have been set up; the code appears to work fine without contracts in place.
Changing the
show-dataspecs to not mock the outdatedness checker is rather difficult at this point, however.To do
Related issues
Fixes #1428.