Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in show-data when printing layout outdatedness #1432

Merged
merged 1 commit into from May 4, 2019

Conversation

@ddfreyne
Copy link
Member

commented May 4, 2019

Detailed description

show-data prints the outdatedness status of layouts. Unfortunately, the tests mock out the outdatedness checker, and the real outdatedness checker does not permit calling outdated_due_to_dependencies? on layouts, only items and item reps.

This appears to be mostly a problem with the contracts that have been set up; the code appears to work fine without contracts in place.

Changing the show-data specs to not mock the outdatedness checker is rather difficult at this point, however.

To do

  • Tests

Related issues

Fixes #1428.

@ddfreyne ddfreyne force-pushed the gh-1428-outdated-due-to-dependencies-for-layout branch from 5078ff4 to 5e09c2d May 4, 2019

@ddfreyne ddfreyne merged commit 57fd535 into master May 4, 2019

21 checks passed

ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f402851...5e09c2d
Details
codecov/project 97.74% (+<.01%) compared to f402851
Details

@ddfreyne ddfreyne deleted the gh-1428-outdated-due-to-dependencies-for-layout branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.