Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in show-data when printing layout outdatedness #1432

Merged

Conversation

denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented May 4, 2019

Detailed description

show-data prints the outdatedness status of layouts. Unfortunately, the tests mock out the outdatedness checker, and the real outdatedness checker does not permit calling outdated_due_to_dependencies? on layouts, only items and item reps.

This appears to be mostly a problem with the contracts that have been set up; the code appears to work fine without contracts in place.

Changing the show-data specs to not mock the outdatedness checker is rather difficult at this point, however.

To do

  • Tests

Related issues

Fixes #1428.

@denisdefreyne denisdefreyne force-pushed the gh-1428-outdated-due-to-dependencies-for-layout branch from 5078ff4 to 5e09c2d Compare May 4, 2019
@denisdefreyne denisdefreyne merged commit 57fd535 into master May 4, 2019
21 checks passed
@denisdefreyne denisdefreyne deleted the gh-1428-outdated-due-to-dependencies-for-layout branch May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant