Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying excluded files across all checks #1438

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@ddfreyne
Copy link
Member

commented May 18, 2019

Detailed description

This allows specifying files to exclude across all checks. Previously, each check had its own way to specify files to exclude.

To exclude certain files, list then under the exclude_files property, under the all property of checks, e.g.

checks:
  all:
    exclude_files:
      - bad.html
      - worse.html

To do

  • Tests
  • Documentation
  • Update JSON schema

Related issues

Closes nanoc/features#51.

@ddfreyne ddfreyne force-pushed the common-exclude-files branch 3 times, most recently from 0572ffb to 0f4ecf0 Jun 14, 2019

@ddfreyne ddfreyne force-pushed the common-exclude-files branch from 0f4ecf0 to 9c7a5a3 Jul 6, 2019

@ddfreyne ddfreyne force-pushed the common-exclude-files branch from 9c7a5a3 to 320427f Aug 11, 2019

Allow specifying excluded files across all checks
This allows specifying files to exclude across all checks. Previously, each check had its own way to specify files to exclude.

To exclude certain files, list then under the `exclude_files` property, under the `all` property of `checks`, e.g.

```
checks:
  all:
    exclude_files:
      - bad.html
      - worse.html
```

Closes nanoc/features#51.

@ddfreyne ddfreyne force-pushed the common-exclude-files branch from 320427f to 91cd154 Aug 11, 2019

@ddfreyne ddfreyne merged commit df9d119 into master Aug 11, 2019

21 checks passed

ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 11526a6...91cd154
Details
codecov/project 97.77% (+<.01%) compared to 11526a6
Details

@ddfreyne ddfreyne deleted the common-exclude-files branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.