Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency tracking for sass imports #1452

Merged
merged 1 commit into from Aug 17, 2019

Conversation

Ecco
Copy link
Contributor

@Ecco Ecco commented Aug 14, 2019

Fixes #1451. Not sure it's the cleanest way, but it sure is the shortest way 馃槃

@denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented Aug 17, 2019

This fix is correct, though is missing tests 鈥 but arguably, that is not an easy thing to test. I will give this a try after I merge this PR.

(For future readers of this PR: This fix is correct because the map that is built in-memory is rebuilt on every invocation of Nanoc, and so can't lead to outdated information that exists because information was cached.)

Thank you for the fix!

@denisdefreyne denisdefreyne merged commit 5296d55 into nanoc:master Aug 17, 2019
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants