Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diffs faster and more correct #1455

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@ddfreyne
Copy link
Member

commented Sep 7, 2019

Detailed description

By using Diff::LCS directly, we avoid unnecessary file writes. Additionally, we can assume that the diff is generated for textual files (determined by Nanoc), and avoid TTY::File’s in-this-case annoying decision to not handle seemingly-binary files.

To do

n/a

Related issues

(none)

Make diffs faster and more correct
By using Diff::LCS directly, we avoid unnecessary file writes. Additionally, we can assume that the diff is generated for textual files (determined by Nanoc), and avoid TTY::File’s in-this-case annoying decision to not handle seemingly-binary files.

@ddfreyne ddfreyne force-pushed the faster-safer-diff branch from e86970e to 61c9afa Sep 7, 2019

@ddfreyne ddfreyne merged commit bda846f into master Sep 7, 2019

21 checks passed

ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 975a011...61c9afa
Details
codecov/project 97.36% (+0.01%) compared to 975a011
Details

@ddfreyne ddfreyne deleted the faster-safer-diff branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.