Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diffs faster and more correct #1455

Merged
merged 1 commit into from Sep 7, 2019
Merged

Conversation

denisdefreyne
Copy link
Member

@denisdefreyne denisdefreyne commented Sep 7, 2019

Detailed description

By using Diff::LCS directly, we avoid unnecessary file writes. Additionally, we can assume that the diff is generated for textual files (determined by Nanoc), and avoid TTY::File’s in-this-case annoying decision to not handle seemingly-binary files.

To do

n/a

Related issues

(none)

By using Diff::LCS directly, we avoid unnecessary file writes. Additionally, we can assume that the diff is generated for textual files (determined by Nanoc), and avoid TTY::File’s in-this-case annoying decision to not handle seemingly-binary files.
@denisdefreyne denisdefreyne merged commit bda846f into master Sep 7, 2019
21 checks passed
@denisdefreyne denisdefreyne deleted the faster-safer-diff branch Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant