Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pruner print things on dry run #1476

Merged
merged 1 commit into from Dec 24, 2019
Merged

Conversation

@ddfreyne
Copy link
Member

ddfreyne commented Dec 24, 2019

The notification center approach works only during compilation; invoking nanoc prune won’t set up the right notification listeners.

CC @Fjan

Detailed description

The output has also changed slightly, to reflect the actual “delete” log entry more closely.

To do

  • Tests

Related issues

Fixes #1474

The notification center approach works only during compilation; invoking `nanoc prune` won’t set up the right notification listeners.
@ddfreyne ddfreyne merged commit 561a0a5 into master Dec 24, 2019
27 checks passed
27 checks passed
ci/circleci: check_style_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: setup_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_guard_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_core_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_deploying_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_deploying_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_deploying_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_external_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_live_cruby26 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_spec_cruby24 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_spec_cruby25 Your tests passed on CircleCI!
Details
ci/circleci: test_nanoc_spec_cruby26 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing af61425...602605a
Details
codecov/project 96.52% (-0.01%) compared to af61425
Details
@ddfreyne ddfreyne deleted the fix-prune-not-printing-on-dry-run branch Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.