nanoc-cli: Only try to clean UTF-8 chars from UTF-8 strings #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when attempting to load a custom filter in a Windows Nanoc installation, Nanoc was crashing with indications that the UTF-8 stream cleaner was unable to process the supplied string. Now, we only attempt to clean UTF-8 characters out of the string if it is UTF-8 encoded. Should fix nanoc#1502. (Including the contracts gem issue).
Co-authored-by: Denis Defreyne <denis@denis.ws>
Co-authored-by: Denis Defreyne <denis@denis.ws>
|
😅 thanks for the review 🙂 |
|
Thank you for the fix! |
|
You're welcome 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Previously, when attempting to load a custom filter in a Windows Nanoc
installation, Nanoc was crashing with indications that the UTF-8 stream cleaner
was unable to process the supplied string.
Now, we only attempt to clean UTF-8 characters out of the string if it is UTF-8
encoded.
To do
(Include the to-do list for this PR to be finished here.)
Related issues
Should fix #1502. (Including the contracts gem issue).