Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding links from the internal_links checker #242

Merged
merged 1 commit into from Mar 10, 2013

Conversation

Projects
None yet
3 participants
@remko
Copy link
Contributor

commented Feb 24, 2013

Links to be excluded can be specified as a list of regular
expressions in config[:checks][:internal_links][:exclude].

Allow excluding links from the internal_links checker.
Links to be excluded can be specified as a list of regular
expressions in config[:checks][:internal_links][:exclude].
@ddfreyne

This comment has been minimized.

Copy link
Member

commented Feb 27, 2013

Looks good to me.

@bobthecow Merge if you are satisfied as well!

@ghost ghost assigned bobthecow Feb 27, 2013

@bobthecow

This comment has been minimized.

Copy link
Member

commented Feb 27, 2013

My only concern here would be that none of the rest of the configuration is supplied as regex (it all uses globbing instead)

@ddfreyne

This comment has been minimized.

Copy link
Member

commented Feb 27, 2013

I don’t think there’s any place where globs are used in the configuration file.

@bobthecow

This comment has been minimized.

Copy link
Member

commented Feb 27, 2013

Oh, heh. What do you know. That was a monkeypatch I wrote to keep nanoc prune from pruning my *.gz files :)

@remko

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2013

So, are there any more concerns? Thanks!

ddfreyne added a commit that referenced this pull request Mar 10, 2013

Merge pull request #242 from remko/master
Allow excluding links from the internal_links checker

@ddfreyne ddfreyne merged commit 7f3928d into nanoc:master Mar 10, 2013

1 check failed

default The Travis build could not complete due to an error
Details
@ddfreyne

This comment has been minimized.

Copy link
Member

commented Mar 10, 2013

No concerns! Merged!

I kept this pull request open for a while on purpose in order to use it for a demonstration of pull requests. :)

@bobthecow

This comment has been minimized.

Copy link
Member

commented Mar 11, 2013

Sorry about that, I completely forgot that you were waiting on my merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.