New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checks file naming variants #255

Merged
merged 1 commit into from Feb 27, 2013

Conversation

Projects
None yet
3 participants
@cdlm
Contributor

cdlm commented Feb 26, 2013

No description provided.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Feb 27, 2013

Member

Hmm, I’m not sure about this.

I consider the fact that Rules can have four different names a mistake: I should have stuck with Rules only. A .rb extension could be useful for syntax highlighting, but a #!/usr/bin/env ruby would solve that too.

So, allowing different filenames for Checks is something I’d rather not do. I am a proponent of “consistently wrong” though, and it would apply in this case.

Member

ddfreyne commented Feb 27, 2013

Hmm, I’m not sure about this.

I consider the fact that Rules can have four different names a mistake: I should have stuck with Rules only. A .rb extension could be useful for syntax highlighting, but a #!/usr/bin/env ruby would solve that too.

So, allowing different filenames for Checks is something I’d rather not do. I am a proponent of “consistently wrong” though, and it would apply in this case.

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Feb 27, 2013

Member

@ddfreyne A counterpoint to that would be that I had to change my rules filenames when i added import_rules to the DSL. On a case-insensitive filesystem, you can't have a folder named rules/ and a file named Rules, so I now use rules.rb and rules/.

Member

bobthecow commented Feb 27, 2013

@ddfreyne A counterpoint to that would be that I had to change my rules filenames when i added import_rules to the DSL. On a case-insensitive filesystem, you can't have a folder named rules/ and a file named Rules, so I now use rules.rb and rules/.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Feb 27, 2013

Member

Alright, I’m convinced.

@cdlm Can you make this pull request on master instead of release-3.6.x? Edit: release branch is fine

Member

ddfreyne commented Feb 27, 2013

Alright, I’m convinced.

@cdlm Can you make this pull request on master instead of release-3.6.x? Edit: release branch is fine

ddfreyne added a commit that referenced this pull request Feb 27, 2013

Merge pull request #255 from cdlm/checks-bikeshedding
Allow checks file naming variants

@ddfreyne ddfreyne merged commit 3100531 into nanoc:release-3.6.x Feb 27, 2013

1 check failed

default The Travis build failed
Details
@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Feb 27, 2013

Member

Alternatively, we could implement that "explicit directory / path config" thing we talked about back in the day, then the only hardcoded filename would be config.yaml / nanoc.yaml :)

Member

bobthecow commented Feb 27, 2013

Alternatively, we could implement that "explicit directory / path config" thing we talked about back in the day, then the only hardcoded filename would be config.yaml / nanoc.yaml :)

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Feb 27, 2013

Member

I think there’s enough configuration options already, so I’m not in favour of adding new ones.

Member

ddfreyne commented Feb 27, 2013

I think there’s enough configuration options already, so I’m not in favour of adding new ones.

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Feb 27, 2013

Member

I disagree. I still can't change the location of my tmp directory (unless this was added when I wasn't paying attention?)

Member

bobthecow commented Feb 27, 2013

I disagree. I still can't change the location of my tmp directory (unless this was added when I wasn't paying attention?)

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Feb 27, 2013

Member

Moved to a new issue #259.

Member

ddfreyne commented Feb 27, 2013

Moved to a new issue #259.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 3, 2013

Member

Important change for code quality: 238a378 removes all work from the constructor (because a constructor should never do any work).

Member

ddfreyne commented Mar 3, 2013

Important change for code quality: 238a378 removes all work from the constructor (because a constructor should never do any work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment