New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special DOCTYPE treatment in relativize_paths filter #296

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Apr 1, 2013

The relativize_paths filter has odd behavior that filters out DOCTYPEs in the body of the content. This should not happen, because the relativize_paths filter can only realistically be run on the entire document, and not on document fragments.

See also #291, the original pull request with a test case. (This pull request replaces the original pull request.)

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 1, 2013

Member

@bobthecow Review and merge.

Member

ddfreyne commented Apr 1, 2013

@bobthecow Review and merge.

bobthecow added a commit that referenced this pull request Apr 1, 2013

Merge pull request #296 from ddfreyne/bug-remove-doctype-treatment-in…
…-relativize-paths-filter

Remove special DOCTYPE treatment in relativize_paths filter

@bobthecow bobthecow merged commit 50b3747 into nanoc:release-3.6.x Apr 1, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment