New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teardown listeners after compile #301

Merged
merged 5 commits into from Apr 7, 2013

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Apr 5, 2013

The compilation listeners (diff generator, file action printer, …) are not shut down after compilation has finished. This causes the teardown actions not to be called, which causes problems:

  • output.diff is sometimes not generated correctly (#225)
  • Profiling information is not printed
  • The garbage collector is not re-enabled (although I suspect the effects of this are minimal)
  • Skipped items are never printed

The max_filter_name_length change was necessary because the max_filter_name_length variable is not actually defined. D’oh!

I am not sure how to test this properly. Ideas are welcome!

@ghost ghost assigned bobthecow Apr 5, 2013

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 6, 2013

Member

I added a test case.

@bobthecow Review and merge.

Member

ddfreyne commented Apr 6, 2013

I added a test case.

@bobthecow Review and merge.

@ghost ghost assigned bobthecow Apr 6, 2013

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Apr 7, 2013

Member

👍

Member

bobthecow commented Apr 7, 2013

👍

bobthecow added a commit that referenced this pull request Apr 7, 2013

@bobthecow bobthecow merged commit 112401c into nanoc:release-3.6.x Apr 7, 2013

1 check failed

default The Travis build failed
Details

@ddfreyne ddfreyne deleted the ddfreyne:bug-teardown-listeners-after-compile branch Apr 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment