Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks in the content directory #302

Merged
merged 12 commits into from Apr 10, 2013
Merged

Follow symlinks in the content directory #302

merged 12 commits into from Apr 10, 2013

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 7, 2013

This lets the filesystem data source follow symlinks in content/, up to 10 times.

Fixes #212 and #299, and closes #300.

@ghost ghost assigned bobthecow Apr 7, 2013
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 7, 2013

@bobthecow Review and merge.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 7, 2013

Wait with this for a bit. I would like to tackle #213 at the same time.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 7, 2013

Now also includes a fix for #213.

@bobthecow Review and merge.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 7, 2013

Hmm, this doesn’t take symlinks to symlinks into account. :(

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 7, 2013

@bobthecow Review and merge.

Loading

else
raise UnsupportedFileTypeError.new(fn)
end
end.compact.flatten
Copy link
Member

@bobthecow bobthecow Apr 10, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add .sort here to save us all sorts of support questions :)

Loading

bobthecow added a commit that referenced this issue Apr 10, 2013
@bobthecow bobthecow merged commit 6265169 into nanoc:release-3.6.x Apr 10, 2013
1 check failed
Loading
@ddfreyne ddfreyne deleted the bug-follow-symlinks-in-content branch Apr 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants