Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sass filtered items dependencies #306

Merged
merged 2 commits into from Apr 23, 2013

Conversation

@gpakosz
Copy link
Member

@gpakosz gpakosz commented Apr 18, 2013

This pull requests contains two commits:

  • to make Item#raw_filename avaialble on text items
  • to make Sass filter use item.raw_filename instead of item[:content_filename]
gpakosz added 2 commits Apr 18, 2013
Use item.raw_filename instead of item[:content_filename] to prevent Sass filter
from creating a dependency on every item in the site.
ddfreyne added a commit that referenced this issue Apr 23, 2013
@ddfreyne ddfreyne merged commit 939dc14 into nanoc:master Apr 23, 2013
1 check failed
Loading
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 23, 2013

I don’t like giving special meaning to attributes (in this case, :content_filename) but I think the advantages (significantly less dependencies) outweigh the drawbacks.

In any case, nanoc 4.0 will make this obsolete when identifiers will be the same as filenames… once I get to that. :)

Loading

@gpakosz gpakosz deleted the reduce_sass_filter_dependencies branch Apr 23, 2013
ddfreyne added a commit that referenced this issue Sep 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants