Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency tracker stack not empty after error #329

Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Aug 31, 2013

This is a fix for #325.

Suggestions for a better, more high-level, black box test are more than welcome.

@ghost ghost assigned bobthecow Aug 31, 2013
@bobthecow
Copy link
Member

@bobthecow bobthecow commented Aug 31, 2013

👍

Loading

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Aug 31, 2013

Would it also make sense to throw an exception at the end of compilation if the stack isn't empty, so we actually know if there are other similar issues?

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Aug 31, 2013

Absolutely. Added!

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Aug 31, 2013

@bobthecow Merge if satisfied.

Loading

bobthecow added a commit that referenced this issue Aug 31, 2013
…mpty-after-error

Dependency tracker stack not empty after error
@bobthecow bobthecow merged commit f2c1fd7 into release-3.6.x Aug 31, 2013
1 check failed
Loading
@ddfreyne ddfreyne deleted the bug/dependency-tracker-stack-not-empty-after-error branch Aug 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants