New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency tracker stack not empty after error #329

Merged
merged 2 commits into from Aug 31, 2013

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Aug 31, 2013

This is a fix for #325.

Suggestions for a better, more high-level, black box test are more than welcome.

@ghost ghost assigned bobthecow Aug 31, 2013

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Aug 31, 2013

Member

👍

Member

bobthecow commented Aug 31, 2013

👍

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Aug 31, 2013

Member

Would it also make sense to throw an exception at the end of compilation if the stack isn't empty, so we actually know if there are other similar issues?

Member

bobthecow commented Aug 31, 2013

Would it also make sense to throw an exception at the end of compilation if the stack isn't empty, so we actually know if there are other similar issues?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 31, 2013

Member

Absolutely. Added!

Member

ddfreyne commented Aug 31, 2013

Absolutely. Added!

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Aug 31, 2013

Member

@bobthecow Merge if satisfied.

Member

ddfreyne commented Aug 31, 2013

@bobthecow Merge if satisfied.

bobthecow added a commit that referenced this pull request Aug 31, 2013

Merge pull request #329 from nanoc/bug/dependency-tracker-stack-not-e…
…mpty-after-error

Dependency tracker stack not empty after error

@bobthecow bobthecow merged commit f2c1fd7 into release-3.6.x Aug 31, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@ddfreyne ddfreyne deleted the bug/dependency-tracker-stack-not-empty-after-error branch Aug 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment