New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double compilation when capturing #337

Merged
merged 3 commits into from Sep 29, 2013

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Sep 20, 2013

This fixes #331.

The problem is that the current implementation recompiles the content twice, which in the case of Haml means that compiled Haml content (i.e. HTML) gets interpreted as Haml and recompiled, which will fail because HTML is not Haml, hence the “nesting within plain text is illegal” error.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 21, 2013

Member

If anyone has a good idea for how to write a decent test for this, let me know. ;)

Member

ddfreyne commented Sep 21, 2013

If anyone has a good idea for how to write a decent test for this, let me know. ;)

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Sep 29, 2013

Member

👍

Member

gpakosz commented Sep 29, 2013

👍

ddfreyne added a commit that referenced this pull request Sep 29, 2013

@ddfreyne ddfreyne merged commit 28221d2 into release-3.6.x Sep 29, 2013

@ddfreyne ddfreyne deleted the bug/double-compilation-when-capturing branch Sep 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment