Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix a few bugs when using the fog deployer with a path specified #351
A few fixes for the fog deployer when using a path. In our particular use case we are deploying documentation for our different environments (staging, production) to separate prefixes in a single S3 bucket.
I attempted to write tests for test_run_delete_stray when a path is set, but as the local fog provider doesn't have any concept of prefixes this wasn't possible. If you have any idea how this could be tested I'd be more than happy to implement it.
Cool stuff, thanks!
It is pretty inconvenient that the local provider does not support prefixes. I can’t think of a way to test this properly. Maybe the local fog provider should be adjusted and take a prefix into account, but I don’t know whether the fog maintainers will accept such a change since it would probably break backwards compatibility.
I’ll merge the PR, but if you come up with a nice test, you’re always welcome to send another PR. :)