New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing compilation durations #379

Merged
merged 2 commits into from Dec 27, 2013

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Dec 27, 2013

The :compilation_ended event is sent after :rep_written, so when the action is printed, the timing information won’t be available yet.

This PR lets nanoc determine the timing information when the rep is written, not when compilation has ended.

Fixes #374.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Dec 27, 2013

Member

@bobthecow Please review

Member

ddfreyne commented Dec 27, 2013

@bobthecow Please review

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Dec 27, 2013

Member

👍

Member

bobthecow commented Dec 27, 2013

👍

ddfreyne added a commit that referenced this pull request Dec 27, 2013

@ddfreyne ddfreyne merged commit 126404d into release-3.6.x Dec 27, 2013

@ddfreyne ddfreyne deleted the bug/missing-compilation-durations branch Dec 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment