New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for Nokogiri modifying input on JRuby #416

Merged
merged 4 commits into from Apr 13, 2014

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Apr 12, 2014

Nokogiri on JRuby modifies the encoding of the incoming content, which results in a “cannot modify frozen variable” error when used together with nanoc.

This PR moves the parsing in a separate #parse method, which catches frozen errors and retries with a duplicate of the input.

Please note: There are a bunch of failing/erroring tests on JRuby at the moment. Fixing these is not the purpose of this PR, but I will get to those tests soon.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne
Member

ddfreyne commented Apr 13, 2014

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Apr 13, 2014

Member

👍

Member

bobthecow commented Apr 13, 2014

👍

ddfreyne added a commit that referenced this pull request Apr 13, 2014

Merge pull request #416 from nanoc/bug/nokogiri-on-jruby-frozen-content
Add workaround for Nokogiri modifying input on JRuby

@ddfreyne ddfreyne merged commit 15c85e0 into release-3.6.x Apr 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the bug/nokogiri-on-jruby-frozen-content branch Apr 13, 2014

@ddfreyne ddfreyne removed the to review label Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment