New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parent_config_file support in configuration file #419

Merged
merged 1 commit into from Apr 28, 2014

Conversation

Projects
None yet
2 participants
@gpakosz
Member

gpakosz commented Apr 13, 2014

This replaces #414.

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Apr 16, 2014

Member

How about now?

Member

gpakosz commented Apr 16, 2014

How about now?

YAML.load_file(config_path).symbolize_keys_recursively
end
def apply_parent_config(config, config_paths = [])

This comment has been minimized.

@ddfreyne

ddfreyne Apr 28, 2014

Member

I’d prefer config_paths to be a Set rather than an array (there is no need to have it ordered).

A better name for this param would be seen_config_paths.

@ddfreyne

ddfreyne Apr 28, 2014

Member

I’d prefer config_paths to be a Set rather than an array (there is no need to have it ordered).

A better name for this param would be seen_config_paths.

ddfreyne added a commit that referenced this pull request Apr 28, 2014

Merge pull request #419 from gpakosz/parent_config_file-support
Added parent_config_file support in configuration file

@ddfreyne ddfreyne merged commit df88011 into nanoc:master Apr 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 28, 2014

Member

It’s fine!

Member

ddfreyne commented Apr 28, 2014

It’s fine!

@ddfreyne ddfreyne removed the to review label Apr 28, 2014

@gpakosz gpakosz deleted the gpakosz:parent_config_file-support branch Jul 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment