Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not catch USR1 on JRuby #426

Merged
merged 1 commit into from May 1, 2014
Merged

Do not catch USR1 on JRuby #426

merged 1 commit into from May 1, 2014

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 23, 2014

Attempting to catch USR1 on the JVM raises the following message:

The signal USR1 is in use by the JVM and will not work correctly on this platform

Potential fix for #425.

There are no tests for this change; I don’t think it’s possible to write a reasonable test for this.

Attempting to catch USR1 on the JVM raises the following message:

> The signal USR1 is in use by the JVM and will not work correctly on this
> platform
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 24, 2014

Loading

@gpakosz
Copy link
Member

@gpakosz gpakosz commented Apr 29, 2014

Seem my comments on #425: why not trap SIGABRT, print the stack trace, then abort?

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 1, 2014

@gpakosz Aborting wasn’t what I had in mind when I added the USR1 functionality. I don’t think printing a stack trace and aborting is super useful.

Loading

@gpakosz
Copy link
Member

@gpakosz gpakosz commented May 1, 2014

alright, then it seems you can't do much but don't trap SIGUSR1 when running under JRuby

Loading

ddfreyne added a commit that referenced this issue May 1, 2014
@ddfreyne ddfreyne merged commit 5ab3f08 into release-3.6.x May 1, 2014
1 check passed
Loading
@ddfreyne ddfreyne deleted the fix/disable-usr1-on-jruby branch May 1, 2014
@ddfreyne ddfreyne mentioned this pull request May 1, 2014
@ddfreyne ddfreyne removed the to review label May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants