Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksummer #431

Merged
merged 9 commits into from May 2, 2014

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

ddfreyne commented May 1, 2014

This creates a Checksummer class responsible for creating checksums. Having checksumming logic in a single place is much better from a maintainability point of view.

It also modifies the way checksums are generated. It no longer uses #inspect unless absolutely necessary, which should fix #310 properly.

This PR also changes checksums from hex form (e.g. 3df63b7acb0522da685dad5fe84b81fdd7b25264) to Base 64 form (e.g. mL+TaqNsEeiPkWloPgCtAofT1yg=) to reduce space.

@bobthecow

This comment has been minimized.

Copy link
Member

bobthecow commented May 1, 2014

👍

ddfreyne added a commit that referenced this pull request May 2, 2014

@ddfreyne ddfreyne merged commit beec6a4 into release-3.6.x May 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the checksummer branch May 2, 2014

@ddfreyne ddfreyne removed the to review label Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.