New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete root temp directory eventually #444

Merged
merged 1 commit into from Jun 8, 2014

Conversation

Projects
None yet
3 participants
@ddfreyne
Member

ddfreyne commented Jun 8, 2014

This is a potential for #440.

#cleanup will now delete the root directory if the temp filename factory is no longer being used.

@ddfreyne ddfreyne added the bug label Jun 8, 2014

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 8, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 231a6e0 on remove-root-tmp-directory into 933f56b on master.

coveralls commented Jun 8, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 231a6e0 on remove-root-tmp-directory into 933f56b on master.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 8, 2014

Member

Tests are expected to fail until #443 is merged.

Member

ddfreyne commented Jun 8, 2014

Tests are expected to fail until #443 is merged.

@ddfreyne ddfreyne added the to review label Jun 8, 2014

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Jun 8, 2014

Member

👍

Member

bobthecow commented Jun 8, 2014

👍

ddfreyne added a commit that referenced this pull request Jun 8, 2014

Merge pull request #444 from nanoc/remove-root-tmp-directory
Delete root temp directory eventually

@ddfreyne ddfreyne merged commit 80873ed into master Jun 8, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jun 8, 2014

Member

I also transplanted (cherry-picked) this so that it’s on the release-3.6.x branch too.

Member

ddfreyne commented Jun 8, 2014

I also transplanted (cherry-picked) this so that it’s on the release-3.6.x branch too.

@ddfreyne ddfreyne deleted the remove-root-tmp-directory branch Jun 8, 2014

@ddfreyne ddfreyne removed the to review label Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment