Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete root temp directory eventually #444

Merged
merged 1 commit into from Jun 8, 2014
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 8, 2014

This is a potential for #440.

#cleanup will now delete the root directory if the temp filename factory is no longer being used.

@ddfreyne ddfreyne added the bug label Jun 8, 2014
@coveralls
Copy link

@coveralls coveralls commented Jun 8, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 231a6e0 on remove-root-tmp-directory into 933f56b on master.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Jun 8, 2014

Tests are expected to fail until #443 is merged.

Loading

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Jun 8, 2014

👍

Loading

ddfreyne added a commit that referenced this issue Jun 8, 2014
Delete root temp directory eventually
@ddfreyne ddfreyne merged commit 80873ed into master Jun 8, 2014
1 check failed
Loading
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Jun 8, 2014

I also transplanted (cherry-picked) this so that it’s on the release-3.6.x branch too.

Loading

@ddfreyne ddfreyne deleted the remove-root-tmp-directory branch Jun 8, 2014
@ddfreyne ddfreyne removed the to review label Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants