New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN support #451

Merged
merged 1 commit into from Sep 6, 2014

Conversation

Projects
None yet
3 participants
@kost
Contributor

kost commented Jun 17, 2014

Implemented support for CDN

if cdn_id is specified, it will invalidate objects on CDN.

Implemented fixes as Fog does not support dry run. Also, basic test is implemented.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 17, 2014

Coverage Status

Coverage decreased (-0.02%) when pulling 082372d on kost:cdn-support into 1ab8a19 on nanoc:master.

coveralls commented Jun 17, 2014

Coverage Status

Coverage decreased (-0.02%) when pulling 082372d on kost:cdn-support into 1ab8a19 on nanoc:master.

@kost

This comment has been minimized.

Show comment
Hide comment
@kost

kost Jul 28, 2014

Contributor

Any problem with the pull/patch?

Contributor

kost commented Jul 28, 2014

Any problem with the pull/patch?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jul 29, 2014

Member

My apologies. I haven’t had the time to review it yet.

Member

ddfreyne commented Jul 29, 2014

My apologies. I haven’t had the time to review it yet.

@kost

This comment has been minimized.

Show comment
Hide comment
@kost

kost Sep 6, 2014

Contributor

Thanks. implemented all suggestions. Let me know if there's anything else.

Contributor

kost commented Sep 6, 2014

Thanks. implemented all suggestions. Let me know if there's anything else.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 6, 2014

Member

Looks good otherwise. Can you squash your six commits together? I’ll merge afterwards.

Member

ddfreyne commented Sep 6, 2014

Looks good otherwise. Can you squash your six commits together? I’ll merge afterwards.

@ddfreyne ddfreyne added waiting and removed to review labels Sep 6, 2014

@kost

This comment has been minimized.

Show comment
Hide comment
@kost

kost Sep 6, 2014

Contributor

That should be it.

Contributor

kost commented Sep 6, 2014

That should be it.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 6, 2014

Member

Thanks!

Member

ddfreyne commented Sep 6, 2014

Thanks!

ddfreyne added a commit that referenced this pull request Sep 6, 2014

@ddfreyne ddfreyne merged commit 7f2b9b1 into nanoc:master Sep 6, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@ddfreyne ddfreyne removed the waiting label Sep 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment