Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN support #451

Merged
merged 1 commit into from Sep 6, 2014
Merged

CDN support #451

merged 1 commit into from Sep 6, 2014

Conversation

@kost
Copy link
Contributor

@kost kost commented Jun 17, 2014

Implemented support for CDN

if cdn_id is specified, it will invalidate objects on CDN.

Implemented fixes as Fog does not support dry run. Also, basic test is implemented.

@coveralls
Copy link

@coveralls coveralls commented Jun 17, 2014

Coverage Status

Coverage decreased (-0.02%) when pulling 082372d on kost:cdn-support into 1ab8a19 on nanoc:master.

Loading

@kost
Copy link
Contributor Author

@kost kost commented Jul 28, 2014

Any problem with the pull/patch?

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jul 29, 2014

My apologies. I haven’t had the time to review it yet.

Loading

@@ -65,6 +72,7 @@ def run
files = files + set
end
keys_to_destroy = files.all.map { |file| file.key }
keys_to_invalidate = Array.new
Copy link
Member

@ddfreyne ddfreyne Sep 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idiomatic Ruby uses [] instead of Array.new.

Loading

@kost
Copy link
Contributor Author

@kost kost commented Sep 6, 2014

Thanks. implemented all suggestions. Let me know if there's anything else.

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Sep 6, 2014

Looks good otherwise. Can you squash your six commits together? I’ll merge afterwards.

Loading

@ddfreyne ddfreyne added waiting and removed to review labels Sep 6, 2014
@kost
Copy link
Contributor Author

@kost kost commented Sep 6, 2014

That should be it.

Loading

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Sep 6, 2014

Thanks!

Loading

ddfreyne added a commit that referenced this issue Sep 6, 2014
@ddfreyne ddfreyne merged commit 7f2b9b1 into nanoc:master Sep 6, 2014
1 check was pending
Loading
@ddfreyne ddfreyne removed the waiting label Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants