New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made #make_rule_memory_serializable() use Nanoc::Checksummer #461

Merged
merged 1 commit into from Jul 20, 2014

Conversation

Projects
None yet
3 participants
@gpakosz
Member

gpakosz commented Jul 15, 2014

This should fix #310 once and for all.

When integrating with Compass, one would typically use the :sass filter the following way:

filter :sass, Compass.sass_engine_options

However, upon each call to Compass.sass_engine_options new instances of Sass::Importers::Filesystem and Compass::SpriteImporter populate the :load_paths array. Those classes don't implement #inspect and ultimately the default #inspect implementation returns a string containing a different memory address upon each invocation.

This confuses Nanoc which believes rules have changed since the item was last compiled:

/foo/ is outdated: The rules file has been modified since the last time the site was compiled.
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jul 15, 2014

Member

Sweet, will review this more closely later and include it in the next 3.7.x release.

Member

ddfreyne commented Jul 15, 2014

Sweet, will review this more closely later and include it in the next 3.7.x release.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 15, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 25bf35e on gpakosz:rule-memory-checksum into 613f6ec on nanoc:release-3.7.x.

coveralls commented Jul 15, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling 25bf35e on gpakosz:rule-memory-checksum into 613f6ec on nanoc:release-3.7.x.

ddfreyne added a commit that referenced this pull request Jul 20, 2014

Merge pull request #461 from gpakosz/rule-memory-checksum
Made #make_rule_memory_serializable() use Nanoc::Checksummer

@ddfreyne ddfreyne merged commit a15c601 into nanoc:release-3.7.x Jul 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ddfreyne ddfreyne added the enhancement label Aug 9, 2014

@gpakosz gpakosz deleted the gpakosz:rule-memory-checksum branch Sep 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment