New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added :commands_dirs (Array<String>) support to configuration file. #475

Merged
merged 1 commit into from Sep 6, 2014

Conversation

Projects
None yet
2 participants
@gpakosz
Member

gpakosz commented Sep 6, 2014

Makes nanoc load commands from configurable directories.

This replaces the hardcoded commands path by @config[:commands_dirs].

Added :commands_dirs (Array<String>) support to configuration file.
Makes nanoc load commands from configurable directories.
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 6, 2014

Member

Looks good!

Member

ddfreyne commented Sep 6, 2014

Looks good!

ddfreyne added a commit that referenced this pull request Sep 6, 2014

Merge pull request #475 from gpakosz/configurable-commands_dirs
Added :commands_dirs (Array<String>) support to configuration file.

@ddfreyne ddfreyne merged commit 892adb9 into nanoc:master Sep 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz Apr 15, 2015

Member

Could this be viewed as an enhancement of #424 instead of a new feature? I'm afraid 3.8 won't be out any time soon.

Member

gpakosz commented Apr 15, 2015

Could this be viewed as an enhancement of #424 instead of a new feature? I'm afraid 3.8 won't be out any time soon.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 15, 2015

Member

I’m OK with releasing 3.8 soon, even if it doesn’t bring a lot of new stuff to the table. In that case, I’d aim for a release this weekend.

Member

ddfreyne commented Apr 15, 2015

I’m OK with releasing 3.8 soon, even if it doesn’t bring a lot of new stuff to the table. In that case, I’d aim for a release this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment