Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better style #476

Merged
merged 23 commits into from Sep 16, 2014
Merged

Better style #476

merged 23 commits into from Sep 16, 2014

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Sep 6, 2014

This updates the nanoc code so that it adheres with the existing guidelines.

It also brings the code a bit closer to the common Ruby style guidelines. It’s not quite there yet, but fixing all offences would take a lot of time.

@ddfreyne ddfreyne added this to the 3.7.4 milestone Sep 6, 2014
@ddfreyne ddfreyne mentioned this pull request Sep 6, 2014
ddfreyne added a commit that referenced this issue Sep 16, 2014
@ddfreyne ddfreyne merged commit 55651a6 into release-3.7.x Sep 16, 2014
1 check passed
Loading
@ddfreyne ddfreyne deleted the better-style branch Sep 16, 2014
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Sep 16, 2014

Approved by a colleague!

Loading

ddfreyne added a commit that referenced this issue Nov 23, 2014
@ddfreyne ddfreyne mentioned this pull request Nov 29, 2014
ddfreyne added a commit that referenced this issue Nov 29, 2014
This is the second part of my crusade against non-standard code style;
the first part being #476. There are two reasons why these changes were
not in #476:

1. Rubocop got updated with a lot of new checks, and this PR ensures we
   adhere to the guidelines set forth in that new Rubocop.

2. I got over the attachment to my personal preferences (such as TODO’s
   not being postfixed by a colon).
ddfreyne added a commit that referenced this issue Nov 30, 2014
This is the second part of my crusade against non-standard code style;
the first part being #476. There are two reasons why these changes were
not in #476:

1. Rubocop got updated with a lot of new checks, and this PR ensures we
   adhere to the guidelines set forth in that new Rubocop.

2. I got over the attachment to my personal preferences (such as TODO’s
   not being postfixed by a colon).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant