New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap data source use/unuse in transaction so we are sure of the unuse #491

Merged
merged 1 commit into from Nov 3, 2014

Conversation

Projects
None yet
3 participants
@mpapis
Member

mpapis commented Nov 3, 2014

extracted from #481

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 3, 2014

Member

👍

Member

bobthecow commented Nov 3, 2014

👍

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 3, 2014

Member

Apart from comment, sweet 👍

Member

ddfreyne commented Nov 3, 2014

Apart from comment, sweet 👍

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 3, 2014

Member

I’d leave out the “and are always unused” — it’s pretty confusing.

Member

ddfreyne commented Nov 3, 2014

I’d leave out the “and are always unused” — it’s pretty confusing.

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 3, 2014

Member

updated

Member

mpapis commented Nov 3, 2014

updated

ddfreyne added a commit that referenced this pull request Nov 3, 2014

Merge pull request #491 from mpapis/features/ensure_datasources_unuse
Wrap data source #use/#unuse in transaction

@ddfreyne ddfreyne merged commit 684604f into nanoc:release-3.7.x Nov 3, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 3, 2014

Member

Thanks!

Member

ddfreyne commented Nov 3, 2014

Thanks!

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 3, 2014

Member

my pleasure :)

Member

mpapis commented Nov 3, 2014

my pleasure :)

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 3, 2014

Member

I’d leave out the “and are always unused” — it’s pretty confusing.

Maybe "and are released after completion" or something?

Member

bobthecow commented Nov 3, 2014

I’d leave out the “and are always unused” — it’s pretty confusing.

Maybe "and are released after completion" or something?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 3, 2014

Member

Maybe "and are released after completion" or something?

They’re not necessarily released, since this uses reference counting.

Member

ddfreyne commented Nov 3, 2014

Maybe "and are released after completion" or something?

They’re not necessarily released, since this uses reference counting.

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 3, 2014

Member

gotcha. okay. leave it out then :)

Member

bobthecow commented Nov 3, 2014

gotcha. okay. leave it out then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment