Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Rouge class from pre rather than code #502

Merged
merged 1 commit into from Dec 6, 2014
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 30, 2014

Rouge’s HTML formatter was changed so that the class appears on the
pre element rather than the code element.

See also rouge-ruby/rouge#191.

Rouge’s HTML formatter was changed so that the class appears on the
`pre` element rather than the `code` element.

See also rouge-ruby/rouge#191.
@ddfreyne ddfreyne added this to the 3.7.5 milestone Nov 30, 2014
@ddfreyne ddfreyne mentioned this pull request Nov 30, 2014
@mpapis
Copy link
Member

@mpapis mpapis commented Nov 30, 2014

don't we need to change some dependencies so proper gem version of Rouge is used?

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Nov 30, 2014

There’s no dependency on Rouge anywhere; it is loaded whenever rouge is used in the colorize_syntax filter.

It’s not ideal, but that’s how it is.

Loading

@mpapis
Copy link
Member

@mpapis mpapis commented Nov 30, 2014

just an idea, what if it was extracted to separate gem/plugin and then we coudl define the dependency in it.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Nov 30, 2014

That’s what the nanoc 4.x work is about (although it’s been pretty quiet on that front lately).

Loading

@mpapis
Copy link
Member

@mpapis mpapis commented Nov 30, 2014

I will be happy to help with 4.x some time soon

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Nov 30, 2014

Can I get a +1?

Loading

@mpapis
Copy link
Member

@mpapis mpapis commented Nov 30, 2014

👍 it matches the mentioned ticket

Loading

@mpapis mpapis mentioned this pull request Dec 1, 2014
ddfreyne added a commit that referenced this issue Dec 6, 2014
Take Rouge class from pre rather than code
@ddfreyne ddfreyne merged commit 3b3f103 into release-3.7.x Dec 6, 2014
1 check passed
Loading
@ddfreyne ddfreyne deleted the fix-rouge-class branch Dec 6, 2014
@mpapis mpapis mentioned this pull request Dec 6, 2014
ddfreyne added a commit that referenced this issue Jan 4, 2015
@ddfreyne ddfreyne mentioned this pull request Jan 4, 2015
7 tasks
ddfreyne added a commit that referenced this issue Jan 11, 2015
@ddfreyne ddfreyne removed the to review label Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants