New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Rouge class from pre rather than code #502

Merged
merged 1 commit into from Dec 6, 2014

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Nov 30, 2014

Rouge’s HTML formatter was changed so that the class appears on the
pre element rather than the code element.

See also jneen/rouge#191.

Take Rouge class from pre rather than code
Rouge’s HTML formatter was changed so that the class appears on the
`pre` element rather than the `code` element.

See also jneen/rouge#191.

@ddfreyne ddfreyne added this to the 3.7.5 milestone Nov 30, 2014

@ddfreyne ddfreyne added the to review label Nov 30, 2014

@ddfreyne ddfreyne referenced this pull request Nov 30, 2014

Closed

failing tests from #486 #493

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 30, 2014

Member

don't we need to change some dependencies so proper gem version of Rouge is used?

Member

mpapis commented Nov 30, 2014

don't we need to change some dependencies so proper gem version of Rouge is used?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 30, 2014

Member

There’s no dependency on Rouge anywhere; it is loaded whenever rouge is used in the colorize_syntax filter.

It’s not ideal, but that’s how it is.

Member

ddfreyne commented Nov 30, 2014

There’s no dependency on Rouge anywhere; it is loaded whenever rouge is used in the colorize_syntax filter.

It’s not ideal, but that’s how it is.

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 30, 2014

Member

just an idea, what if it was extracted to separate gem/plugin and then we coudl define the dependency in it.

Member

mpapis commented Nov 30, 2014

just an idea, what if it was extracted to separate gem/plugin and then we coudl define the dependency in it.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 30, 2014

Member

That’s what the nanoc 4.x work is about (although it’s been pretty quiet on that front lately).

Member

ddfreyne commented Nov 30, 2014

That’s what the nanoc 4.x work is about (although it’s been pretty quiet on that front lately).

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 30, 2014

Member

I will be happy to help with 4.x some time soon

Member

mpapis commented Nov 30, 2014

I will be happy to help with 4.x some time soon

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Nov 30, 2014

Member

Can I get a +1?

Member

ddfreyne commented Nov 30, 2014

Can I get a +1?

@mpapis

This comment has been minimized.

Show comment
Hide comment
@mpapis

mpapis Nov 30, 2014

Member

👍 it matches the mentioned ticket

Member

mpapis commented Nov 30, 2014

👍 it matches the mentioned ticket

@mpapis mpapis referenced this pull request Dec 1, 2014

Merged

add dotfiles support #498

ddfreyne added a commit that referenced this pull request Dec 6, 2014

Merge pull request #502 from nanoc/fix-rouge-class
Take Rouge class from pre rather than code

@ddfreyne ddfreyne merged commit 3b3f103 into release-3.7.x Dec 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the fix-rouge-class branch Dec 6, 2014

@mpapis mpapis referenced this pull request Dec 6, 2014

Closed

add typohero filter #477

ddfreyne added a commit that referenced this pull request Jan 4, 2015

@ddfreyne ddfreyne referenced this pull request Jan 4, 2015

Merged

Remove support for Ruby 1.8.x #517

7 of 7 tasks complete

ddfreyne added a commit that referenced this pull request Jan 11, 2015

@ddfreyne ddfreyne removed the to review label Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment