Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTML/CSS validator error messages #504

Merged
merged 2 commits into from Jan 10, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

ddfreyne commented Dec 6, 2014

This improves the error messages generated by the HTML and CSS validators.

Potential fix for #484. CC @dgmstuart

Example for h1 { coxlor: rxed; }:

line 1: Property coxlor doesn't exist: h1 { coxlor: rxed; }

Contrast this with before:

Property coxlor doesn't exist

Example for h1 { ; {:

line 1: Parse Error: h1 { ; {

Contrast this with before:

Parse Error
@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented Dec 6, 2014

It’s probably a good idea to update the HTML check at the same time!

@bobthecow

This comment has been minimized.

Copy link
Member

bobthecow commented Dec 6, 2014

nice!

@ddfreyne ddfreyne changed the title Improve CSS validator error messages Improve HTML/CSS validator error messages Dec 21, 2014

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented Dec 21, 2014

HTML check error messages are better now too. There’s duplication between the CSS and HTML checks, but I’m not sure it’s worth cleaning that up.

@ddfreyne ddfreyne added to review and removed status:wip 🔧 labels Dec 21, 2014

@ddfreyne ddfreyne modified the milestone: 3.7.5 Dec 25, 2014

@ddfreyne ddfreyne force-pushed the better-css-validator-messages branch from 994cd7f to 0fb0f83 Jan 7, 2015

@bobthecow

This comment has been minimized.

Copy link
Member

bobthecow commented Jan 10, 2015

👍 lgtm

@ddfreyne ddfreyne removed the to review label Jan 10, 2015

ddfreyne added a commit that referenced this pull request Jan 10, 2015

Merge pull request #504 from nanoc/better-css-validator-messages
Improve HTML/CSS validator error messages

@ddfreyne ddfreyne merged commit 3bf0cf7 into release-3.7.x Jan 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the better-css-validator-messages branch Jan 10, 2015

ddfreyne added a commit that referenced this pull request Jan 11, 2015

ddfreyne added a commit that referenced this pull request Jan 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.