Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTML/CSS validator error messages #504

Merged
merged 2 commits into from Jan 10, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Dec 6, 2014

This improves the error messages generated by the HTML and CSS validators.

Potential fix for #484. CC @dgmstuart

Example for h1 { coxlor: rxed; }:

line 1: Property coxlor doesn't exist: h1 { coxlor: rxed; }

Contrast this with before:

Property coxlor doesn't exist

Example for h1 { ; {:

line 1: Parse Error: h1 { ; {

Contrast this with before:

Parse Error
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Dec 6, 2014

It’s probably a good idea to update the HTML check at the same time!

Loading

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Dec 6, 2014

nice!

Loading

@ddfreyne ddfreyne changed the title Improve CSS validator error messages Improve HTML/CSS validator error messages Dec 21, 2014
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Dec 21, 2014

HTML check error messages are better now too. There’s duplication between the CSS and HTML checks, but I’m not sure it’s worth cleaning that up.

Loading

@ddfreyne ddfreyne added this to the 3.7.5 milestone Dec 25, 2014
@ddfreyne ddfreyne added this to the 3.7.5 milestone Dec 25, 2014
@ddfreyne ddfreyne force-pushed the better-css-validator-messages branch from 994cd7f to 0fb0f83 Jan 7, 2015
@bobthecow
Copy link
Member

@bobthecow bobthecow commented Jan 10, 2015

👍 lgtm

Loading

ddfreyne added a commit that referenced this issue Jan 10, 2015
Improve HTML/CSS validator error messages
@ddfreyne ddfreyne merged commit 3bf0cf7 into release-3.7.x Jan 10, 2015
1 check passed
Loading
@ddfreyne ddfreyne deleted the better-css-validator-messages branch Jan 10, 2015
ddfreyne added a commit that referenced this issue Jan 11, 2015
ddfreyne added a commit that referenced this issue Jan 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants