Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when compiling extensionless binary items #525

Merged
merged 1 commit into from Jan 31, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

commented Jan 31, 2015

Fix for #524.

@@ -130,7 +130,7 @@ def array_to_yaml(array)
item.identifier.chop + '.css'
elsif item.binary?
# Write item with identifier /foo/ to /foo.ext
item.identifier.chop + '.' + item[:extension]
item.identifier.chop + '.' + (item[:extension] ? '.' + item[:extension] : '')

This comment has been minimized.

Copy link
@mpapis

mpapis Jan 31, 2015

Member

two dots?

This comment has been minimized.

Copy link
@ddfreyne

ddfreyne Jan 31, 2015

Author Member

Oh, doh. That’s clearly wrong.

(Must have been my lack of coffee.)

This comment has been minimized.

Copy link
@ddfreyne

ddfreyne Jan 31, 2015

Author Member

Fixed.

@mpapis

This comment has been minimized.

Copy link
Member

commented Jan 31, 2015

looks good 👍

@ddfreyne ddfreyne force-pushed the fix-extensionless-binary-items-crash branch from 464dc5f to 12b6e8e Jan 31, 2015

ddfreyne added a commit that referenced this pull request Jan 31, 2015

Merge pull request #525 from nanoc/fix-extensionless-binary-items-crash
Fix crash when compiling extensionless binary items

@ddfreyne ddfreyne merged commit 4db567c into release-3.7.x Jan 31, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the fix-extensionless-binary-items-crash branch Jan 31, 2015

@ddfreyne ddfreyne removed the to review label Jan 31, 2015

@ddfreyne ddfreyne added this to the 3.7.6 milestone Apr 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.