Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when compiling extensionless binary items #525

Merged
merged 1 commit into from Jan 31, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 31, 2015

Fix for #524.

@@ -130,7 +130,7 @@ def array_to_yaml(array)
item.identifier.chop + '.css'
elsif item.binary?
# Write item with identifier /foo/ to /foo.ext
item.identifier.chop + '.' + item[:extension]
item.identifier.chop + '.' + (item[:extension] ? '.' + item[:extension] : '')
Copy link
Member

@mpapis mpapis Jan 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two dots?

Loading

Copy link
Member Author

@ddfreyne ddfreyne Jan 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, doh. That’s clearly wrong.

(Must have been my lack of coffee.)

Loading

Copy link
Member Author

@ddfreyne ddfreyne Jan 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Loading

@mpapis
Copy link
Member

@mpapis mpapis commented Jan 31, 2015

looks good 👍

Loading

@ddfreyne ddfreyne force-pushed the fix-extensionless-binary-items-crash branch from 464dc5f to 12b6e8e Jan 31, 2015
ddfreyne added a commit that referenced this issue Jan 31, 2015
Fix crash when compiling extensionless binary items
@ddfreyne ddfreyne merged commit 4db567c into release-3.7.x Jan 31, 2015
1 check was pending
Loading
@ddfreyne ddfreyne deleted the fix-extensionless-binary-items-crash branch Jan 31, 2015
@ddfreyne ddfreyne added this to the 3.7.6 milestone Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants