New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Mixed Content" check #543

Merged
merged 1 commit into from Apr 19, 2015

Conversation

Projects
None yet
2 participants
@jugglinmike
Contributor

jugglinmike commented Apr 18, 2015

Commit message:

This check ensures that resources embedded within HTML documents are not
requested using a protocol that degrades the security of the original
connection. This avoids "mixed content" warnings in browsers that
enforce consistent protocols, and it precludes the leaking of private
information in browsers that do not.

Resolves gh-542

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 18, 2015

Member

This looks good! I’ll do a more in-depth review soon, but I‘m quite liking it so far.

Member

ddfreyne commented Apr 18, 2015

This looks good! I’ll do a more in-depth review soon, but I‘m quite liking it so far.

@ddfreyne ddfreyne added this to the 3.8 milestone Apr 18, 2015

@jugglinmike

This comment has been minimized.

Show comment
Hide comment
@jugglinmike

jugglinmike Apr 18, 2015

Contributor

Great, thanks! I'll hold off on moving that class variable till you get a chance to finish.

Contributor

jugglinmike commented Apr 18, 2015

Great, thanks! I'll hold off on moving that class variable till you get a chance to finish.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 18, 2015

Member

The style checks are failing. Apparently, they’re also failing on other parts of the code—I’ll fix it; ignore the style test results for now.

Member

ddfreyne commented Apr 18, 2015

The style checks are failing. Apparently, they’re also failing on other parts of the code—I’ll fix it; ignore the style test results for now.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 18, 2015

Member

Can you rebase onto master? That should fix the style issues (at least the ones that are not your fault, heh).

Member

ddfreyne commented Apr 18, 2015

Can you rebase onto master? That should fix the style issues (at least the ones that are not your fault, heh).

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 18, 2015

Member

Looks good otherwise!

Member

ddfreyne commented Apr 18, 2015

Looks good otherwise!

@ddfreyne ddfreyne added status:wip 🔧 and removed to review labels Apr 18, 2015

@jugglinmike

This comment has been minimized.

Show comment
Hide comment
@jugglinmike

jugglinmike Apr 18, 2015

Contributor

Alrighty, I've rebased and incorporated your feedback in separate commits. I'm happy to squash when you think this is ready

Contributor

jugglinmike commented Apr 18, 2015

Alrighty, I've rebased and incorporated your feedback in separate commits. I'm happy to squash when you think this is ready

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 18, 2015

Member

Cool! OK to squash. I’ll properly test it out tomorrow and will merge it if it’s OK!

Member

ddfreyne commented Apr 18, 2015

Cool! OK to squash. I’ll properly test it out tomorrow and will merge it if it’s OK!

Implement "Mixed Content" check
This check ensures that resources embedded within HTML documents are not
requested using a protocol that degrades the security of the original
connection. This avoids "mixed content" warnings in browsers that
enforce consistent protocols, and it precludes the leaking of private
information in browsers that do not.
@jugglinmike

This comment has been minimized.

Show comment
Hide comment
@jugglinmike

jugglinmike Apr 18, 2015

Contributor

Excellent--all squashed

Contributor

jugglinmike commented Apr 18, 2015

Excellent--all squashed

ddfreyne added a commit that referenced this pull request Apr 19, 2015

@ddfreyne ddfreyne merged commit 0e7cdad into nanoc:master Apr 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 19, 2015

Member

Thanks!

Member

ddfreyne commented Apr 19, 2015

Thanks!

@jugglinmike

This comment has been minimized.

Show comment
Hide comment
@jugglinmike

jugglinmike Apr 19, 2015

Contributor

My pleasure :)

Contributor

jugglinmike commented Apr 19, 2015

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment