Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double snapshot creation error #547

Merged
merged 1 commit into from May 2, 2015
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented May 1, 2015

The following does not raise an error, but should:

snapshot(:foo, stuff: :giraffe)
snapshot(:foo, stuff: :donkey)

The following does raise an error, but should not:

snapshot(:foo)
snapshot(:bar)

The reason is that uniqueness is tested on the second argument (params), but should be on the first (name).

@ddfreyne ddfreyne force-pushed the fix-double-snapshot-names branch from c3753d8 to c7faebb May 1, 2015
@gpakosz
Copy link
Member

@gpakosz gpakosz commented May 2, 2015

👍

Loading

@ddfreyne ddfreyne removed the to review label May 2, 2015
ddfreyne added a commit that referenced this issue May 2, 2015
@ddfreyne ddfreyne merged commit f8a46ce into release-3.7.x May 2, 2015
2 checks passed
Loading
@ddfreyne ddfreyne deleted the fix-double-snapshot-names branch May 2, 2015
ddfreyne added a commit that referenced this issue May 3, 2015
@ddfreyne ddfreyne added this to the 3.7.6 milestone May 4, 2015
@ddfreyne ddfreyne added this to the 3.7.6 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants