New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double snapshot creation error #547

Merged
merged 1 commit into from May 2, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented May 1, 2015

The following does not raise an error, but should:

snapshot(:foo, stuff: :giraffe)
snapshot(:foo, stuff: :donkey)

The following does raise an error, but should not:

snapshot(:foo)
snapshot(:bar)

The reason is that uniqueness is tested on the second argument (params), but should be on the first (name).

@gpakosz

This comment has been minimized.

Show comment
Hide comment
@gpakosz

gpakosz May 2, 2015

Member

👍

Member

gpakosz commented May 2, 2015

👍

@ddfreyne ddfreyne removed the to review label May 2, 2015

ddfreyne added a commit that referenced this pull request May 2, 2015

@ddfreyne ddfreyne merged commit f8a46ce into release-3.7.x May 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the fix-double-snapshot-names branch May 2, 2015

ddfreyne added a commit that referenced this pull request May 3, 2015

@ddfreyne ddfreyne modified the milestone: 3.7.6 May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment