New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View API convenience methods #572

Merged
merged 1 commit into from May 11, 2015

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented May 11, 2015

Fixes for #570.

Two ugly things:

  • The dependency tracking support. Having to evaluate @item[key] just so the dependency tracking doesn’t break is pretty icky.
  • The amount of duplication. I couldn’t find a clean and non-intrusive way to implement this.

I’m okay with both ugly bits, because they’re abstracted away and we can refactor this later. (I’d love to refactor the dependency tracking out of Nanoc::Int::Item and into the view classes.)

@ddfreyne ddfreyne added to review and removed status:wip 🔧 labels May 11, 2015

@ddfreyne ddfreyne changed the title from View api convenience methods to View API convenience methods May 11, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 11, 2015

Member

Merging this! You can give me a 👍 later.

Member

ddfreyne commented May 11, 2015

Merging this! You can give me a 👍 later.

ddfreyne added a commit that referenced this pull request May 11, 2015

@ddfreyne ddfreyne merged commit 6d9b5af into master May 11, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ddfreyne ddfreyne deleted the view-api-convenience-methods branch May 11, 2015

@ddfreyne ddfreyne modified the milestone: 4.0.0 Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment