Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make globs and indentifiers with extensions the default #592

Merged
merged 2 commits into from May 18, 2015

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented May 17, 2015

  • Make globs the default
  • Make identifiers with extensions the default

I don’t like the option names for enabling/disabling these (pattern_syntax: glob/null and identifier_style: full/stripped).

@ddfreyne ddfreyne changed the title Make glob patterns the default Make globs and indentifiers with extensions the default May 17, 2015
@bobthecow
Copy link
Member

@bobthecow bobthecow commented May 18, 2015

stripped is weird. null is weird. glob isn't the best, but at least it's accurate.

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 18, 2015

More ideas for identifiers:

  • identifier_type: with_ext
  • identifier_type: without_ext

And for patterns:

  • pattern_type: glob
  • pattern_type: legacy_wildcard
  • pattern_type: legacy

(I prefer _type more than syntax/style.)

Loading

@bobthecow
Copy link
Member

@bobthecow bobthecow commented May 18, 2015

I'm leaning toward:

  • identifier_type: full
  • identifier_type: legacy

and

  • pattern_type: glob
  • pattern_type: legacy

Let's make it very clear why the second option for each exists.

Loading

@gpakosz
Copy link
Member

@gpakosz gpakosz commented May 18, 2015

I'm with @bobthecow

Loading

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 18, 2015

I’ll follow up with a second PR that changes the names to what @bobthecow suggests.

Loading

ddfreyne added a commit that referenced this issue May 18, 2015
Make globs and indentifiers with extensions the default
@ddfreyne ddfreyne merged commit 072b15b into master May 18, 2015
1 check passed
Loading
@ddfreyne ddfreyne deleted the default-glob-and-identifiers-with-ext branch May 18, 2015
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented May 18, 2015

See #593.

Loading

@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants