Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make globs and indentifiers with extensions the default #592

Merged
merged 2 commits into from May 18, 2015

Conversation

Projects
None yet
3 participants
@ddfreyne
Copy link
Member

commented May 17, 2015

  • Make globs the default
  • Make identifiers with extensions the default

I don’t like the option names for enabling/disabling these (pattern_syntax: glob/null and identifier_style: full/stripped).

@ddfreyne ddfreyne changed the title Make glob patterns the default Make globs and indentifiers with extensions the default May 17, 2015

@ddfreyne ddfreyne added to review and removed status:wip 🔧 labels May 17, 2015

@bobthecow

This comment has been minimized.

Copy link
Member

commented May 18, 2015

stripped is weird. null is weird. glob isn't the best, but at least it's accurate.

@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented May 18, 2015

More ideas for identifiers:

  • identifier_type: with_ext
  • identifier_type: without_ext

And for patterns:

  • pattern_type: glob
  • pattern_type: legacy_wildcard
  • pattern_type: legacy

(I prefer _type more than syntax/style.)

@bobthecow

This comment has been minimized.

Copy link
Member

commented May 18, 2015

I'm leaning toward:

  • identifier_type: full
  • identifier_type: legacy

and

  • pattern_type: glob
  • pattern_type: legacy

Let's make it very clear why the second option for each exists.

@gpakosz

This comment has been minimized.

Copy link
Member

commented May 18, 2015

I'm with @bobthecow

@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented May 18, 2015

I’ll follow up with a second PR that changes the names to what @bobthecow suggests.

ddfreyne added a commit that referenced this pull request May 18, 2015

Merge pull request #592 from nanoc/default-glob-and-identifiers-with-ext
Make globs and indentifiers with extensions the default

@ddfreyne ddfreyne merged commit 072b15b into master May 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the default-glob-and-identifiers-with-ext branch May 18, 2015

@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented May 18, 2015

See #593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.