New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename identifier_style and pattern_syntax #593

Merged
merged 5 commits into from May 19, 2015

Conversation

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented May 18, 2015

Old:

  • identifier_style"full" / "stripped"
  • pattern_syntax"glob" / nil

New:

  • identifier_type"full" / "legacy"
  • string_pattern_type"glob" / "legacy"
Show outdated Hide outdated NEWS.md Outdated
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 18, 2015

Member

Hm, two things:

  • The constructor of Nanoc::Identifier has an optional :style argument. It currently defaults to "legacy', but that’s not what we want. Maybe having it mandatory (as :type) makes sense, or we default to "full".
  • pattern_type might be better as string_pattern_type. Regexes are also patterns, but pattern_type doesn’t apply to that.
Member

ddfreyne commented May 18, 2015

Hm, two things:

  • The constructor of Nanoc::Identifier has an optional :style argument. It currently defaults to "legacy', but that’s not what we want. Maybe having it mandatory (as :type) makes sense, or we default to "full".
  • pattern_type might be better as string_pattern_type. Regexes are also patterns, but pattern_type doesn’t apply to that.

@ddfreyne ddfreyne referenced this pull request May 18, 2015

Merged

Make globs and indentifiers with extensions the default #592

2 of 2 tasks complete
@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow May 18, 2015

Member

I'd say name the argument (and instance variable) type and default it to full.

Member

bobthecow commented May 18, 2015

I'd say name the argument (and instance variable) type and default it to full.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 18, 2015

Member

Letting it default to :full seems like it belongs in a separate PR. I agree though.

Is this PR good to go?

Member

ddfreyne commented May 18, 2015

Letting it default to :full seems like it belongs in a separate PR. I agree though.

Is this PR good to go?

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 18, 2015

Member

Oh yeah, hm, I would like to replace pattern_type with string_pattern_type.

Member

ddfreyne commented May 18, 2015

Oh yeah, hm, I would like to replace pattern_type with string_pattern_type.

@ddfreyne ddfreyne added to review and removed status:wip 🔧 labels May 18, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 18, 2015

Member

Renamed.

Member

ddfreyne commented May 18, 2015

Renamed.

@ddfreyne ddfreyne changed the title from Rename identifier_style to identifier_type to Rename identifier_style and pattern_syntax May 18, 2015

ddfreyne added a commit that referenced this pull request May 19, 2015

@ddfreyne ddfreyne merged commit 2d4a54e into master May 19, 2015

@ddfreyne ddfreyne deleted the rename-identifier-and-pattern-options branch May 19, 2015

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne May 19, 2015

Member

Merged. Hope it’s good :)

Member

ddfreyne commented May 19, 2015

Merged. Hope it’s good :)

@ddfreyne ddfreyne removed the to review label May 19, 2015

@ddfreyne ddfreyne modified the milestone: 4.0.0 Jun 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment